Upgrading nyc to bump up handlebars #771
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #771 +/- ##
==========================================
+ Coverage 95.26% 95.32% +0.06%
==========================================
Files 182 182
Lines 7132 7229 +97
Branches 245 245
==========================================
+ Hits 6794 6891 +97
Misses 305 305
Partials 33 33
Continue to review full report at Codecov.
|
tasawernawaz
approved these changes
Aug 21, 2019
tasawernawaz
left a comment
tasawernawaz
left a comment
There was a problem hiding this comment.
works fine 👍
It looks like new version of eslint throwing lot of errors. You have to fix them.
Member
|
@annagav Should we close this, or keep it open and try again later? |
collinpreston
force-pushed
the
master
branch
from
e5e282f to
f8e3d0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Fix security alert for handlebars
What's this PR do?
Upgrade
nycHow should this be manually tested?
nothing should break